adds stream::skip_while combinator #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Sep 21, 2019
src/stream/stream/mod.rs
Outdated
| @@ -51,6 +52,7 @@ use fold::FoldFuture; | |||
| use min_by::MinByFuture; | |||
| use next::NextFuture; | |||
| use nth::NthFuture; | |||
| use skip_while::SkipWhile; | |||
There was a problem hiding this comment.
Let's export SkipWhile (see lines 40-43 above).
The general policy is that we don't re-export Future types because functions that return them will eventually become async fns, while we do export Stream types.
There was a problem hiding this comment.
ah, i see now, makes sense.
ghost
approved these changes
Sep 21, 2019
|
bors r+ |
Merge conflict (retrying...) |
Merge conflict |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 21, 2019
223: adds stream::skip_while combinator r=stjepang a=montekki Ref: #129 Stdlib: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.skip_while Co-authored-by: Fedor Sakharov <fedor.sakharov@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #129
Stdlib: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.skip_while